Reinitialize the result_buffer - Fix bug where "streaks" were shown on output Bitmaps #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the displayio's `fill_area` function, it does not copy anything for pixels where no Group, TileGrid, or VectorIO is present. In this library, this was causing previous values in the result_buffer to be recopied to the output bitmap file whenever a "un-owned" pixel is observed. This reinitializes the `result_buffer` to be sure that any "un-owned" pixels are made black in the output bitmap file. Resolves issue: adafruit#8
|
This is now clearing all the checks including the “duplicate code” issue. |
kmatch98
changed the title
|
Just bumping this one, since I think all comments were addressed. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 7, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 4.3.3 from 4.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#104 from kattni/main-fix > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.6.0 from 3.5.8: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#68 from yeyeto2788/master > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.2.7 from 1.2.6: > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#20 from adafruit/linting > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_RockBlock to 1.3.3 from 1.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_RockBlock#21 from adafruit/linting > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.9.3 from 1.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#32 from adafruit/linting > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.2.4 from 5.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#68 from brentru/validate-feed-keys-used > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.3.7 from 1.3.6: > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#21 from adafruit/linting > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.1.6 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#14 from kmatch98/patch-2 > "Increase duplicate code check threshold " > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#17 from FoamyGuy/pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.3.5 from 0.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#15 from adafruit/linting > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BoardTest to 1.2.6 from 1.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_BoardTest#15 from adafruit/linting > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_datetime#8 from adafruit/jepler-integer-total_seconds > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.18.3 from 2.18.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#150 from jposada202020/advanced_example > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#149 from jposada202020/optimizing_getting_font_info Updating https://github.com/adafruit/Adafruit_CircuitPython_RGBLED to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_RGBLED#15 from adafruit/dherrada-patch-1 > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_RSA#18 from adafruit/linting > "Increase duplicate code check threshold "
This was referenced Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the displayio's
fill_areafunction, it does not copy anything for pixels where no Group, TileGrid, or VectorIO is present. In this library, this was causing previous values in the result_buffer to be recopied to the output bitmap file whenever a "un-owned" pixel is observed.This reinitializes the
result_bufferto be sure that any "un-owned" pixels are made black in the output bitmap file.Resolves issue:
#8